fixed Translation issue send-friend in send.phtml#18889
Merged
magento-engcom-team merged 4 commits into2.3-developfrom Oct 31, 2018
unknown repository
Merged
fixed Translation issue send-friend in send.phtml#18889magento-engcom-team merged 4 commits into2.3-developfrom unknown repository
magento-engcom-team merged 4 commits into2.3-developfrom
unknown repository
Conversation
added 4 commits
October 25, 2018 23:31
Contributor
|
Hi @rahulwebkul. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
approved these changes
Oct 27, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
ghost
mentioned this pull request
4 tasks
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 31, 2018
Contributor
|
Hi @rahulwebkul. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
I think there is no need to use escapeJs method as we are already using escapeHtml method.
Due to this string getting converted in hexadecimal.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Add translation in module-send-friend module. put Name -> Na-me:. string will become Na\u002Dme\u003A
Contribution checklist (*)